Features/nialljmiller/customcolors update1#929
Conversation
…CSV is made per filter per history write.
…enotes absolute path
Correct formatting issues in README.rst for clarity.
Removed reference to synthetic photometry and bolometric quantities in the README.
…evert to file IO per call. This is slow but prevents crashing.
|
@nialljmiller you can leave this pr open here, and open a new pr to the https://github.com/MESAHub/mesa/tree/r25.12.1_colors_updated branch I made for you. And then we can try to pack it up and export it once it passes testing! |
|
I would also recommend we cherry-pick all the changes that go into the new release branch to main as well. That way we don't have any divergences or uncertainty about what ended up where. |
|
Can we also pull @VincentVanlaer's SIMD bug fix into this branch, so that summer school attendees who use the 26.3.2 SDK won't run into the bugs that the SDK exposed? |
I think that's a good idea. We can cherry pick that commit into the branch. |
|
This is the commit correct? 03ef2a5 |
4 participants
Update to colors to address issue #928 and #927 as well as adding 'sed_per_model' and 'colors_per_newton_step'
colors/private/colors_utils.f90 now has "resolve_path" which only uses MESA_DIR when appropriate. (This addresses issue Relative instrument and other paths for Colors do not work #927)
colors module README and custom_colors test suite README have been updated. (This addresses issue Colors module documentation #928)
'sed_per_model' has been added which, when enabled, appends the model number to the SED files. This means that one CSV file is made per filter per history write. This was added from user feedback.
'colors_per_newton_step' enables the colors module to be called per newton iterations. This edit touches : star/private/history.f90, star/job/run_star_support.f90, star/private/init.f90, and star/public/star_lib.f90. It also adds colors/private/colors_iteration.f90.
various python helper files have been modified and added. To allow for more complete testing of features in the colors module